2.0 Station losing cargo space

[RoseStarlight]

My station are running out of cargo space despite having cargo space. For example, i'll build a station with a maximum of 30k cargo, and over time it will slowly decrease over a few hours despite it still saying 30k max cargo. Eventually the stations stop functioning because it thinks there isnt any cargo space left even if the station is completely empty.

If i replace the cargo holds, or reinstall cargo hold modules, it will temporarily fix the issue.

Does anyone know whats causing this issue and if i can fix it? I'd rather not reset *all* of my stations hold every 2 hours.

[Xenomorph-Alpha]

Hey,

Have this bug too, wrote at the start of 2.0 beta branch a bug report detailed, how this bug can be reproduced and also with screenshot what is happening (also with code examples). I really do not know if they are still working on the issue or can not reproduce it.

At the moment of 2.0.7 i have still this bug (no mods, clean world, clean installation with clean %appdata%/avorion folder, and can not fix that myself. Easiest way is to restart the server. The captian command "supply factories" is causing the bug. If he delivered goods to the destinantion the origin station losing free cargo space somehow. Has to be something with the sector simulation i think.  So in short, no. you have to restart the server or not use the supply factories command. 

[IcyFireDeluxe]

Hey there,

have the same Bug and also did a bug report last year, but since then no news whatsoever on that topic.

I also found out restarting the local game or in my case the SERVER!!! works until it is magically full again.

It's really frustrating not to know if it will be fixed. Me and my friends totally stopped playing the game for that reason.

I also spent a lot of time trying to fix that issue, it was extremely annoying.

After spending a lot of time with factories, they feel super capped altogether, which is a shame, because I read it was different in the past.

[Xenomorph-Alpha]

was looking here in the forum if this bug was resolved. Seems not, so i will not play the game further. Cause i really like the "build a empire stuff".  It is sad that there is no response to this bug, and if need i would dig into the code too help. But as i wrote last year. It seems to be a bug in the core game.

It seems also that focus is not on stations at this point and it could be that only a minority of players are getting problems with this behaviour.

 

Orillien seems to have the same bug.

 

[koonschi]

We cannot reproduce the issue and hence cannot fix it. Can you provide the exact station plan xml and what kind of factory it is? Is this limited to a specific factory? Does the issue occur if you stay in the same sector and idle or is it for a factory that's in another sector than you? 

Edit: what cargo is on the station, (before and after the issue occurs), can you provide a screenshot maybe? 

[Xenomorph-Alpha]

13 hours ago, koonschi said:

We cannot reproduce the issue and hence cannot fix it. Can you provide the exact station plan xml and what kind of factory it is? Is this limited to a specific factory? Does the issue occur if you stay in the same sector and idle or is it for a factory that's in another sector than you? 

Edit: what cargo is on the station, (before and after the issue occurs), can you provide a screenshot maybe? 

Thank you for your response. I will dig into it. I will send this afternoon the screenshots i made with some explanation how.

I only have time on tuesday to reproduce the error. I can if it help say you also then which variable (i mean it was just a getter which was from core) is doing this problem.

[Xenomorph-Alpha]

So as  i said in earlier posts in only happens with the use of the "supply factories" command.

 

In this example i used the water collector and the ressource water.

for reproducing:

 

Build Station A in one Sector

Build Station B in another Sector

Create Supply Line between those booth. (with the command!)

After goods getting transfered. The goods getting substracted from the provider station and the reciever station getting theses added ( i getting this bug if i am in the sector, and if i am not in the sector).

But like you can see in the pictures below (i added som print debug code to see what is in the variables)

the free cargo space variable is not getting recalculated somehow. so if the station is loosing with the time and the command cargo. the free cargo variable is getting messed up. So that even he is loosing more cargo he thinks he has no cargo left anymore.

If you add cargo to it, it will work, but will stuck in some time again. 

To reproduce it is ideal to use a station with very less cargo, so the bug happens fast.

I think it was the sector simulation.lua where it happens. But for more i can only check tomorrow sorry. (for the exact variables and the file where it happens, and where the point he is messing with the calculation) But for sure i know that he is getting the Free Cargo space from the core game as a (was a getter) so i was not able to fix it for myself to make the caluclation.

i hope this is helping. Tomorrow more if needed.

 

 

[Rymaca]

Thank you for your effort!

We still couldn't reproduce the bug. It would therefore be very helpful if you could share more information about the variables you mentioned and where you found them exactly.

[koonschi]

Factories reserve a portion of their cargo hold for each ingredient/product they need/produce, to ensure that they can't block their own cargo space with, say, only products. Have you checked that your factories aren't running into that limit? You can see that maximum per good on the Sell/Buy tabs of your factory, when you interact as if you wanted to buy or sell stuff. It would be particularly helpful if you could provide us with a screenshot of those tabs of the factory. 

Also, where did you get your "station free cargo" output? I'd need the exact line of code and where you put it.

[Xenomorph-Alpha]

Thank you for your answer!

 

So as i promised with a little more info.

I cleaned my folders, reinstalled the game. (and for sure no mods)

Created a new sandbox game.

Set up a water collector in sector A and a FishFarm in Sector B. That set up a supply factory command with a captian.

I could reproduce the bug, because i let the watercollector run full to max storage and then after the first supply run i saw the bug again.

 

Down here the pictures with new prints:

In the first four pictures you see how the cargo space is running slowly full with water you can see what the max cargo count is how much the resulting amount is gonna be, the new amount an the free cargo space left in the cargo.

All numbers are change as expected.

In the fift picture you can see that the simulation of the command is finished. The Cargo bar is also changing as expected. But the numbers stay the same.

Of course the new amount is not so much anymore cause that he has not so many water in his cargo anymore. But the max stock stays the same. And also the free cargo space stays the same. So he thinks he is full. 

 

If a trader is buying water, it recalculates correctly. If I dump cargo or build new modules on it, i solve it for a time but he will never will completely up.

If i restart the game, an so the server (singleplayer) it recalculates everything correct until the next command is getting fullfilled.

 

I checking the variable in the factory.lua in the Factory.update Production(timeStep)

i filtered my station with a simple if condition on the name and printed following variables out.

Factory.getMaxStock({name = result.name, size = size})

newAmount)

 result.amount * size

canProduce

station.freeCargoSpace

 

3 hours ago, koonschi said:

Factories reserve a portion of their cargo hold for each ingredient/product they need/produce, to ensure that they can't block their own cargo space with, say, only products. Have you checked that your factories aren't running into that limit? You can see that maximum per good on the Sell/Buy tabs of your factory, when you interact as if you wanted to buy or sell stuff. It would be particularly helpful if you could provide us with a screenshot of those tabs of the factory. 

Also, where did you get your "station free cargo" output? I'd need the exact line of code and where you put it.

Sorry i really do not know what you mean with the Sell/Buy Tab of my factory. The last picture is from the tab which i think you mean.

I hope i can help you with this information

 

 

here the code of the function and on the end my simpe print commands. Thank you for your effort!

function Factory.updateProduction(timeStep)

    -- if the result isn't there yet, don't produce

    if not production then return end

 

    -- if not yet fully used, start producing

    local numProductions = tablelength(currentProductions)

    local canProduce = true

 

    if numProductions >= Factory.maxNumProductions then

        canProduce = false

        -- print("can't produce as there are no more slots free for production")

    end

 

    if MinimumPopulation and not MinimumPopulation.isFulfilled() then

        canProduce = false

        -- print("can't produce as min pop isn't fulfilled")

    end

 

    -- only start if there are actually enough ingredients for producing

    for i, ingredient in pairs(production.ingredients) do

        if ingredient.optional == 0 and Factory.getNumGoods(ingredient.name) < ingredient.amount then

            canProduce = false

            newProductionError = "Factory can't produce because ingredients are missing!"%_T

            -- print("can't produce due to missing ingredients: " .. ingredient.amount .. " " .. ingredient.name .. ", have: " .. Factory.getNumGoods(ingredient.name))

            break

        end

    end

 

    local station = Entity()

    for i, garbage in pairs(production.garbages) do

        local newAmount = Factory.getNumGoods(garbage.name) + garbage.amount

        local size = Factory.getGoodSize(garbage.name)

 

        if newAmount > Factory.getMaxStock({name = garbage.name, size = size}) or station.freeCargoSpace < garbage.amount * size then

            canProduce = false

            newProductionError = "Factory can't produce because there is not enough cargo space for products!"%_T

            -- print("can't produce due to missing room for garbage")

            break

        end

    end

 

    for _, result in pairs(production.results) do

        local newAmount = Factory.getNumGoods(result.name) + result.amount

        local size = Factory.getGoodSize(result.name)

 

        if newAmount > Factory.getMaxStock({name = result.name, size = size}) or station.freeCargoSpace < result.amount * size then

            canProduce = false

            newProductionError = "Factory can't produce because there is not enough cargo space for products!"%_T

            -- print("can't produce due to missing room for result")

            if station.name == "WaterStation 1" then

                print("Name: " .. station.name)

                print("FactoryMaxStock: " .. Factory.getMaxStock({name = result.name, size = size}))

                print("NewAmount: " .. newAmount)

                print("Resulting Amount:" .. result.amount * size)

                print("Can Produce?: " .. tostring(canProduce))

                print("freeCargoSpace: " .. station.freeCargoSpace)

            end

            break

        end

        if station.name == "WaterStation 1" then

            print("Name: " .. station.name)

            print("FactoryMaxStock: " .. Factory.getMaxStock({name = result.name, size = size}))

            print("NewAmount: " .. newAmount)

            print("Resulting Amount:" .. result.amount * size)

            print("Can Produce?: " .. tostring(canProduce))

            print("freeCargoSpace: " .. station.freeCargoSpace)

        end

    end

 

Edited August 23, 2022 by Xenomorph-Alpha

[IcyFireDeluxe]

I didn't know there is something going on on this topic and made a video yesterday randomly to maybe illustrate it much better. maybe it helps in addition to your work here. excuse the bad English and the AC in the back, its 30 degrees at night right now.

Take a look at the production bars of the factory when the module is removed

I never had any mods installed and also had this happen in another singleplayer game

Edited August 24, 2022 by IcyFireDeluxe
no mods info

[Xenomorph-Alpha]

cool thanks for the video. You are also getting that problem only with the AI ships which use the supply factories command?

Yeah restarting and dump stuff helps. Was also thinking about doing a video.

[IcyFireDeluxe]

55 minutes ago, Xenomorph-Alpha said:

cool thanks for the video. You are also getting that problem only with the AI ships which use the supply factories command?

Yeah restarting and dump stuff helps. Was also thinking about doing a video.

yeah exactly, must have something to do with AI ships. In a steam discussion which got deleted I think I said I was trying to get it to work almost 14 hours ... thinking I did something wrong until I saw the discussions. Then some months later I found this post.

Sadly I stopped playing the game back then and only check in every other patch to see if it is fixed.

[IcyFireDeluxe]

I got super hyped when I read the patch notes:

• [UBR] Fixed an issue where the cargo volume wasn't updated correctly when using the Supply operation

but sadly the error still persists until today in version 2.3

 

 

[koonschi]

It's possible that this is a remnant of the previous bug. Try placing a cargo block and see if that fixes the issue.