[0.12.7] Ship duplications and server crashes

[Devious]

The issue of ships duplicating on a server crash still persists after the update, it seems to happen almost every time the server crashes or is shutdown incorrectly.

My guess is that the engine tries to restore a ship from the player saves while one of the other saves is still loaded.

 

We've also been experiencing a few crashes, one noteworthy thing is that it seems to happen when a player is uncorrectly unregistered, which might be because of an unregister callback on logoff from two mods (Out Of Sector Production and Asteroid Mover). As you can see in some of the logs this is not always the case while the crash itself seems to be the same. This crash also happened when we modded the mods to not unregister the callback, it is only since Laserzwei updated his mods that we used his original version again which uses the unregister callbacks.

 

Even when this might be caused by a mod it seems like unexpected behaviour that shouldn't happen, if that is not the case we would value it a lot if you can explain how to prevent this.

 

Through the link below you will find the server logs.

 

https://mega.nz/#!i91i0TCY!FpM4ox-xnlfkeOZ79QTw3RN6G_7j7x2jpaFnFGCHaBo

 

 

 

 

 

[striker_lord]

I'd like to add to this since I somehow managed to duplicate a ship (in the previous version) without a server crash.

I failed to collect the logs at that time but i know what i did, even though repeating the steps didn't reproduce the issue:

- i Created an extra ship (miner) to be piloted by a captain, while creating the ship i remained in the same sector for collecting crew for the ship.

- i took control of my main ship and told the new miner to Escort me

- i jumped to a sector, 7 sectors away, and voila, i had my main ship duplicated

 

The duplicated ship is an exact copy of my ship, the blueprints are connected (if it has damage it will show as damage to my ship even though mine isn't damaged). Once i change the blueprint of my main ship, the duplicate will always report damage because it will now try to match to the new blueprint....

 

In the ship list it won't show up, simply because it is the exact same ship.

I hope this information can be used, sorry for the lack of logs.